Conversation
| # TODO: uncomment and address the 5 failures and 10 errors in iris-grib. | ||
| # - if [[ "${TEST_MINIMAL}" != true ]]; then | ||
| # conda install --quiet -n ${ENV_NAME} python-eccodes; | ||
| # conda install --quiet -n ${ENV_NAME} --no-deps iris-grib; | ||
| # fi |
There was a problem hiding this comment.
Pull the pin and fix these iris-grib related issues... but not in this PR.
|
Hi @bjlittle Just to check I've understood this... To actually re-enable the iris-grib tests, we need to also insert a mention of iris-grib into the Yes? |
|
P.S. To install iris-grib under Python3 for testing, we will also need to install eccodes-python explicitly via pip, as iris-grib currently does with this conda requirement and this pip install Yes? |
|
@pp-mo This is a bit of a mess, and we need to sort this out, but I'd highly recommend that is done outside this PR... Anyways, in an attempt to clarify the This leads me to believe that Anyways, I can see a way forwards using either using Otherwise, I'd suggest we leave the whole debate for later outside this PR. Are you trusting enough to believe me that there is nothing to worry about here? 😈 So |
|
@bjlittle thanks for the clarity.
Yes, given that we all understand that grib testing is still missing, and that's the way we want it ! |
|
@pp-mo Awesome, thanks 👍 |
2 participants
This PR removes Python2
travis-citesting 🎉As a part of technical debt, the appropriate changes are now in place within the
.travis.ymlto commenceiris-gribtests.... however, there are 5 errors and 10 failures that require to be addressed.I'll raise a separate issue to cover this, see #3447.